fix: NPE on named provider init/shutdown (#595)

* fix NPE on named provider init * add condition for not calling shutdown on null old provider Signed-off-by: liran2000 <liran2000@gmail.com>
open-feature · Sep 7, 2023 · d063bf2 · d063bf2
1 parent a2e4894
commit d063bf2
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/main/java/dev/openfeature/sdk/ProviderRepository.java b/src/main/java/dev/openfeature/sdk/ProviderRepository.java
@@ -135,14 +135,15 @@ private void initializeProvider(FeatureProvider newProvider,
     }
 
     private void shutDownOld(FeatureProvider oldProvider,Consumer<FeatureProvider> afterShutdown) {
-        if (!isProviderRegistered(oldProvider)) {
+        if (oldProvider != null && !isProviderRegistered(oldProvider)) {
             shutdownProvider(oldProvider);
             afterShutdown.accept(oldProvider);
         }
     }
 
     private boolean isProviderRegistered(FeatureProvider oldProvider) {
-        return this.providers.containsValue(oldProvider) || this.defaultProvider.get().equals(oldProvider);
+        return oldProvider != null && (this.providers.containsValue(oldProvider)
+            || this.defaultProvider.get().equals(oldProvider));
     }
 
     private void shutdownProvider(FeatureProvider provider) {