Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thread safe in-memory provider #1054

Closed
beeme1mr opened this issue Aug 19, 2024 · 0 comments · Fixed by #1057
Closed

Thread safe in-memory provider #1054

beeme1mr opened this issue Aug 19, 2024 · 0 comments · Fixed by #1057
Labels
good first issue Good for newcomers

Comments

@beeme1mr
Copy link
Member

beeme1mr commented Aug 19, 2024 •
edited by toddbaert
Loading

Update the in-memory provider to be thread safe.

  • Use a ConcurrentHashMap or other mechanisms to ensure the internal flag map is accessible/mutable from multiple threads safely.
  • Ensure other mutable state is synchronized, if any can be identified.
  • No specific additional testing is required, but existing tests should pass.
@beeme1mr beeme1mr added good first issue Good for newcomers help wanted Extra attention is needed labels Aug 19, 2024
@ryanprayogo ryanprayogo mentioned this issue Aug 21, 2024
Merged
@beeme1mr beeme1mr removed the help wanted Extra attention is needed label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Use ConcurrentHashMap for InMemoryProvider ryanprayogo/java-sdk
1 participant
@beeme1mr