Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The SDK Jar does not provide a Module Name #362

Closed
ARobertsCollibra opened this issue Mar 28, 2023 · 4 comments · Fixed by #363
Closed

The SDK Jar does not provide a Module Name #362

ARobertsCollibra opened this issue Mar 28, 2023 · 4 comments · Fixed by #363
Assignees
@toddbaert

Comments

@ARobertsCollibra
Copy link
Member

This is a major issue for developers using both IntelliJ and Gradle due to a Gradle bug

But even when that bug is not present having the automatically created module name be plain sdk is not very descriptive and has a high potential for confusion.

This can be fixed without requiring Java 9 or higher by adding Automatic-Module-Name to the MANIFEST.MF in the published Jar. Alternatively, the project can be updated to compile to Java 11 bytecode and be fully modularized. Currently the contributing guidelines say Java 11+ but the pom.xml say 1.8.
ARobertsCollibra added a commit to ARobertsCollibra/java-sdk that referenced this issue Mar 28, 2023
@ARobertsCollibra
fix: added an automatic module name (open-feature#362)
bb5bc0b
@ARobertsCollibra ARobertsCollibra mentioned this issue Mar 28, 2023
Merged
ARobertsCollibra added a commit to ARobertsCollibra/java-sdk that referenced this issue Mar 28, 2023
@ARobertsCollibra
fix: added an automatic module name (open-feature#362)
2ef2acb
ARobertsCollibra added a commit to ARobertsCollibra/java-sdk that referenced this issue Mar 28, 2023
@ARobertsCollibra
fix: added an automatic module name (open-feature#362)
3c7e6cf 
Signed-off-by: Adam Roberts <adam.roberts@collibra.com>
@toddbaert
Copy link
Member

This can be fixed without requiring Java 9 or higher by adding Automatic-Module-Name to the MANIFEST.MF in the published Jar.

@ARobertsCollibra thanks for bringing this up. I'm ashamed to say I had made a mental note do do exactly this and forgot.

Currently the contributing guidelines say Java 11+ but the pom.xml say 1.8.

Alternatively, the project can be updated to compile to Java 11 bytecode and be fully modularized. Currently the contributing guidelines say Java 11+ but the pom.xml say 1.8.

Good catch, the guidlelines should be updated. We do indeed want to stay with Java8 for now for maximum compatibility, but at some point it makes sense to migrate to 11+ and properly modularize the library. cc @justinabrahms

@toddbaert toddbaert self-assigned this Mar 28, 2023
@toddbaert
Copy link
Member

I've created this in contrib (cc @justinabrahms @Kavindu-Dodan @thiyagu06 )

Kavindu-Dodan added a commit that referenced this issue Mar 28, 2023
@ARobertsCollibra @Kavindu-Dodan
fix: added an automatic module name (#362) (#363)
cfd7086 
* fix: added an automatic module name (#362)

Signed-off-by: Adam Roberts <adam.roberts@collibra.com>

* derive module name

Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>

---------

Signed-off-by: Adam Roberts <adam.roberts@collibra.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Co-authored-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
@github-actions github-actions bot mentioned this issue Mar 28, 2023
Merged
@toddbaert
Copy link
Member

@ARobertsCollibra the fix should available in 1.3.1. If you find time, please confirm.

@ARobertsCollibra
Copy link
Member Author

The problem appears to have been resolved!
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@toddbaert toddbaert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: added an automatic module name (#362) ARobertsCollibra/java-sdk
2 participants
@toddbaert @ARobertsCollibra