Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: expose get value for metadata #468

Merged

Conversation

Kavindu-Dodan
Copy link
Contributor

@Kavindu-Dodan Kavindu-Dodan commented Jun 7, 2023

This PR

Make the getValue method public for FlagMetadata.java. This allows generic value extractions where needed (ex:- Loop across <key, type> and extract them from flag metadata instead of checking for type and calling the exact method).

for (DimensionDescription description:dimensionDescriptions) {
        flagMetadata.getValue(description.getKey(), description.getType());
}

// where 

DimensionDescription is <key of String, type of Class>

@Kavindu-Dodan Kavindu-Dodan requested a review from a team as a code owner June 7, 2023 22:31
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #468 (70ece1a) into main (3946211) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #468   +/-   ##
=========================================
  Coverage     94.44%   94.44%           
  Complexity      268      268           
=========================================
  Files            25       25           
  Lines           612      612           
  Branches         36       36           
=========================================
  Hits            578      578           
  Misses           17       17           
  Partials         17       17           
Flag Coverage Δ
unittests 94.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/main/java/dev/openfeature/sdk/FlagMetadata.java 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Kavindu-Dodan Kavindu-Dodan merged commit 93dde1d into open-feature:main Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants