Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: expose get value for metadata #468

Merged
merged 2 commits into from
Jun 9, 2023
+16 −2
Merged

chore: expose get value for metadata #468

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
287981b
expose get value for metadata
Kavindu-Dodan Jun 7, 2023
70ece1a
Merge branch 'main' into chore/expose-get-value
justinabrahms Jun 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
expose get value for metadata 
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
@Kavindu-Dodan
Kavindu-Dodan committed Jun 8, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
commit 287981b3a0583816ad6b4cb36d177d1647d61088
5 changes: 4 additions & 1 deletion src/main/java/dev/openfeature/sdk/FlagMetadata.java
View file
Original file line number Diff line number Diff line change
@@ -77,7 +77,10 @@ public Boolean getBoolean(final String key) {
return getValue(key, Boolean.class);
}

private <T> T getValue(final String key, final Class<T> type) {
/**
* Generic value retrieval for the given key.
*/
public <T> T getValue(final String key, final Class<T> type) {
final Object o = metadata.get(key);

if (o == null) {
13 changes: 12 additions & 1 deletion src/test/java/dev/openfeature/sdk/FlagMetadataTest.java
View file
Original file line number Diff line number Diff line change
@@ -22,11 +22,22 @@ public void builder_validation() {

// then
assertThat(flagMetadata.getString("string")).isEqualTo("string");
assertThat(flagMetadata.getValue("string", String.class)).isEqualTo("string");

assertThat(flagMetadata.getInteger("integer")).isEqualTo(1);
assertThat(flagMetadata.getValue("integer", Integer.class)).isEqualTo(1);

assertThat(flagMetadata.getLong("long")).isEqualTo(1L);
assertThat(flagMetadata.getValue("long", Long.class)).isEqualTo(1L);

assertThat(flagMetadata.getFloat("float")).isEqualTo(1.5f);
assertThat(flagMetadata.getValue("float", Float.class)).isEqualTo(1.5f);

assertThat(flagMetadata.getDouble("double")).isEqualTo(Double.MAX_VALUE);
assertThat(flagMetadata.getValue("double", Double.class)).isEqualTo(Double.MAX_VALUE);

assertThat(flagMetadata.getBoolean("boolean")).isEqualTo(Boolean.FALSE);
assertThat(flagMetadata.getValue("boolean", Boolean.class)).isEqualTo(Boolean.FALSE);
}

@Test
@@ -38,7 +49,7 @@ public void value_type_validation() {
.build();

// then
assertThat(flagMetadata.getBoolean("string")).isNull();
assertThat(flagMetadata.getBoolean("string")).isNull();
}

@Test