Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug?] initialize should accept global context #475

Closed
toddbaert opened this issue Jun 13, 2023 · 2 comments · Fixed by #476
Closed

[bug?] initialize should accept global context #475

toddbaert opened this issue Jun 13, 2023 · 2 comments · Fixed by #476
Assignees
Labels
bug Something isn't working v0.6.0

Comments

@toddbaert
Copy link
Member

toddbaert commented Jun 13, 2023

As mentioned here by @s-sen , I think we should add a EvaluationContext param here.

I also believe we may want to declare a throws Exception to this method - we already wrap this method in a try/catch when it's called in the SDK, and it's quite realistic to see some initial handshake/etc failing in the init().

This hasn't been released yet, so there's no concern about this being a "breaking" change.

cc @Kavindu-Dodan @justinabrahms @s-sen @lopitz

@toddbaert toddbaert added bug Something isn't working v0.6.0 labels Jun 13, 2023
@Kavindu-Dodan
Copy link
Contributor

Correct, this comes from the requirement Requirement 2.4.1

The provider MAY define an initialize function which accepts the global evaluation context as an argument and performs initialization logic relevant to the provider.

This should be able to fix easily.

@toddbaert
Copy link
Member Author

I've fixed this in #476

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v0.6.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants