-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: events #476
feat: events #476
Conversation
bc6622a
to
ebff404
Compare
Codecov Report
@@ Coverage Diff @@
## main #476 +/- ##
============================================
+ Coverage 94.44% 95.23% +0.78%
- Complexity 268 329 +61
============================================
Files 25 31 +6
Lines 612 755 +143
Branches 36 37 +1
============================================
+ Hits 578 719 +141
- Misses 17 19 +2
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com> Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Co-authored-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com> Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
@open-feature/sdk-java-approvers @open-feature/sdk-java-maintainers I'll be merging this tomorrow EOD unless I hear objections! If you intend to review it and you'd like me to hold-off, or you have any concerns, let me know. This implementation is quite close the to go/js impls, and as far as I can tell is spec adherent. |
Co-authored-by: Justin Abrahms <jabrahms@ebay.com> Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This PR:
EventProvider
and emit events withthis.eventEmitter.emit(event, details);
(and it's similar convenience methods)...on(event, handler)
where handler is ajava.util.function.Consumer<EventDetails>
and it's convenience methods.PROVIDER_READY
/PROVIDER_ERROR
are emitted automatically depending on it's success.See the tests in
EventsTest.java
to get a feel for the API.Fixes: #475
Fixes: #440