Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename flag metadata #478

Merged
merged 1 commit into from
Jun 16, 2023
Merged

chore: rename flag metadata #478

merged 1 commit into from
Jun 16, 2023

Conversation

toddbaert
Copy link
Member

@toddbaert toddbaert commented Jun 15, 2023 •
edited
Loading

Renames the FlagMetadata class (it can be used for event metadata as well). Talked with @Kavindu-Dodan (the implementer) about this. This is not yet released, so there's no breaking change to worry about.

@toddbaert toddbaert requested a review from a team as a code owner June 15, 2023 15:15
Kavindu-Dodan
Kavindu-Dodan approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@Kavindu-Dodan Kavindu-Dodan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, this change allows us to use ImmutableMetadata in many other SDK use cases. For example, in eventing, provider metadata and client metadata can utilize this core implementation without any change. For such usage, we can accept an ImmutableMetadata instance and expose it to extract metadata content

@codecov
Copy link

codecov bot commented Jun 15, 2023 •
edited
Loading

Codecov Report

Merging #478 (516e70b) into main (3501425) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main     #478   +/-   ##
=========================================
  Coverage     94.44%   94.44%           
  Complexity      268      268           
=========================================
  Files            25       25           
  Lines           612      612           
  Branches         36       36           
=========================================
  Hits            578      578           
  Misses           17       17           
  Partials         17       17
Flag Coverage Δ
unittests 94.44% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ava/dev/openfeature/sdk/FlagEvaluationDetails.java 100.00% <ø> (ø)
...in/java/dev/openfeature/sdk/ImmutableMetadata.java 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@toddbaert toddbaert mentioned this pull request Jun 15, 2023
Merged
@beeme1mr beeme1mr requested review from a team June 15, 2023 16:07
@toddbaert
chore: rename flag metadata
516e70b 
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@toddbaert toddbaert merged commit ecfeddf into main Jun 16, 2023
@toddbaert toddbaert deleted the chore/rename-flag-metadata branch June 16, 2023 17:53
@github-actions github-actions bot mentioned this pull request Jun 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kavindu-Dodan Kavindu-Dodan Kavindu-Dodan approved these changes

@beeme1mr beeme1mr beeme1mr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toddbaert @beeme1mr @Kavindu-Dodan