Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usage of EvaluationContext broken by PR #805 #859

Closed
ARobertsCollibra opened this issue Mar 21, 2024 · 0 comments · Fixed by #860
Closed

Usage of EvaluationContext broken by PR #805 #859

ARobertsCollibra opened this issue Mar 21, 2024 · 0 comments · Fixed by #860

Comments

@ARobertsCollibra
Copy link
Member

Usage of EvaluationContext broken by PR #805

When using an Immutable Map either through Collections.unmodifiableMap(...) or Map.of(...) the context attempts to modify the map and crashes.
ARobertsCollibra added a commit to ARobertsCollibra/java-sdk that referenced this issue Mar 21, 2024
@ARobertsCollibra
fix: issue open-feature#859 Added failing tests
7fc10c2
ARobertsCollibra added a commit to ARobertsCollibra/java-sdk that referenced this issue Mar 21, 2024
@ARobertsCollibra
fix: issue open-feature#859 Fixed the logic to allow the tests to pas…
14238ee 
…s by copying the passed in attributes
@ARobertsCollibra ARobertsCollibra mentioned this issue Mar 21, 2024
Merged
ARobertsCollibra added a commit to ARobertsCollibra/java-sdk that referenced this issue Mar 21, 2024
@ARobertsCollibra
fix: issue open-feature#859 Added failing tests
45c3ea1
ARobertsCollibra added a commit to ARobertsCollibra/java-sdk that referenced this issue Mar 21, 2024
@ARobertsCollibra
fix: issue open-feature#859 Fixed the logic to allow the tests to pas…
578877e 
…s by copying the passed in attributes
ARobertsCollibra added a commit to ARobertsCollibra/java-sdk that referenced this issue Mar 21, 2024
@ARobertsCollibra
fix: issue open-feature#859 Added failing tests
bb5557e 
Signed-off-by: Adam Roberts <adam.roberts@collibra.com>
ARobertsCollibra added a commit to ARobertsCollibra/java-sdk that referenced this issue Mar 21, 2024
@ARobertsCollibra
fix: issue open-feature#859 Fixed the logic to allow the tests to pas…
27a1d7f 
…s by copying the passed in attributes

Signed-off-by: Adam Roberts <adam.roberts@collibra.com>
toddbaert pushed a commit to ARobertsCollibra/java-sdk that referenced this issue Mar 22, 2024
@ARobertsCollibra @toddbaert
fix: issue open-feature#859 Added failing tests
ce44071 
Signed-off-by: Adam Roberts <adam.roberts@collibra.com>
toddbaert pushed a commit to ARobertsCollibra/java-sdk that referenced this issue Mar 22, 2024
@ARobertsCollibra @toddbaert
fix: issue open-feature#859 Fixed the logic to allow the tests to pas…
500a688 
…s by copying the passed in attributes

Signed-off-by: Adam Roberts <adam.roberts@collibra.com>
Kavindu-Dodan pushed a commit to ARobertsCollibra/java-sdk that referenced this issue Mar 22, 2024
@ARobertsCollibra @Kavindu-Dodan
fix: issue open-feature#859 Added failing tests
5c76410 
Signed-off-by: Adam Roberts <adam.roberts@collibra.com>
Kavindu-Dodan pushed a commit to ARobertsCollibra/java-sdk that referenced this issue Mar 22, 2024
@ARobertsCollibra @Kavindu-Dodan
fix: issue open-feature#859 Fixed the logic to allow the tests to pas…
3683197 
…s by copying the passed in attributes

Signed-off-by: Adam Roberts <adam.roberts@collibra.com>
Kavindu-Dodan pushed a commit that referenced this issue Mar 22, 2024
@ARobertsCollibra
fix: issue #859 (#860)
d51cacb 
* fix: issue #859 Added failing tests

Signed-off-by: Adam Roberts <adam.roberts@collibra.com>

* fix: issue #859 Fixed the logic to allow the tests to pass by copying the passed in attributes

Signed-off-by: Adam Roberts <adam.roberts@collibra.com>

---------

Signed-off-by: Adam Roberts <adam.roberts@collibra.com>
@github-actions github-actions bot mentioned this issue Mar 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: support immutable maps #859 ARobertsCollibra/java-sdk
1 participant
@ARobertsCollibra