Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implemented tracking as per spec #1228

Merged
merged 4 commits into from
Dec 6, 2024

Conversation

warber
Copy link
Contributor

@warber warber commented Nov 22, 2024

This PR

  • adds support for Tracking as per Spec

Related Issues

Fixes #1164

@warber warber marked this pull request as ready for review November 22, 2024 13:23
@warber warber requested a review from a team as a code owner November 22, 2024 13:23
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.65%. Comparing base (c5ad1b4) to head (48187b5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1228      +/-   ##
============================================
+ Coverage     93.07%   93.65%   +0.58%     
- Complexity      441      465      +24     
============================================
  Files            41       43       +2     
  Lines          1025     1088      +63     
  Branches         85       86       +1     
============================================
+ Hits            954     1019      +65     
+ Misses           44       43       -1     
+ Partials         27       26       -1     
Flag Coverage Δ
unittests 93.65% <100.00%> (+0.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@aepfli aepfli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you the changes look good, but please remove the start imports, and (personal preference) use assertJ for assertions. Plus the comment i wrote regarding the assertCode

src/test/java/dev/openfeature/sdk/TrackingSpecTest.java Outdated Show resolved Hide resolved
@warber warber force-pushed the feat/implement-tracking branch 2 times, most recently from 7831008 to d40050f Compare November 25, 2024 09:02
@aepfli
Copy link
Member

aepfli commented Nov 25, 2024

I will wait for a few more days, to give other @open-feature/sdk-java-maintainers the possibility to respond before merging this. Thank you for the contribution

@toddbaert
Copy link
Member

Will review tomorrow!

@lukas-reining
Copy link
Member

I will also have a look tomorrow if I find time :)

Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@warber warber force-pushed the feat/implement-tracking branch from 92a1d6c to fbef251 Compare December 2, 2024 13:28
@warber warber force-pushed the feat/implement-tracking branch from fbef251 to 1131417 Compare December 2, 2024 13:28
README.md Outdated Show resolved Hide resolved
@warber warber force-pushed the feat/implement-tracking branch from d4b244f to 9987185 Compare December 3, 2024 09:06
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving - I'd love to hear from @justinabrahms before merging though.

Also @warber and other reviewers, please consider this; cc @aepfli @lukas-reining @thomaspoignant @kinyoklion I'm particularly interested in your take on this.

Copy link
Member

@lukas-reining lukas-reining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
I only have one concerns about the numeric value.

Bernd Warmuth added 2 commits December 5, 2024 09:24

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Signed-off-by: Bernd Warmuth <bernd.warmuth@dynatrace.com>

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Signed-off-by: Bernd Warmuth <bernd.warmuth@dynatrace.com>
@warber warber force-pushed the feat/implement-tracking branch from f4eb3e9 to 1ecffec Compare December 5, 2024 08:25
@toddbaert
Copy link
Member

Since this is an SDK change, I'ld like to get a few more approvals before merge.

Copy link
Member

@lukas-reining lukas-reining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
@toddbaert toddbaert changed the title feat: implemented support for tracking feat: implemented tracking as per spec Dec 6, 2024
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
@toddbaert
Copy link
Member

@warber Thanks so much! Merging - I added one small change because I was unclear before when I said:

We might want to add to the docs for .track that it can throw this exception

I meant the Javadocs (though it's fine to put it in the README too). I added this just now: 48187b5

Copy link

sonarqubecloud bot commented Dec 6, 2024

@toddbaert toddbaert merged commit 64ad644 into open-feature:main Dec 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Implement Tracking in Java SDK
7 participants