Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add evaluation details to finally hook stage #1246 #1261

Closed
wants to merge 4 commits into from

Conversation

chrfwow
Copy link
Contributor

@chrfwow chrfwow commented Dec 23, 2024

This PR

Adds FlagEvaluationDetails to finally hooks as per the spec.

  • adds this new feature

Related Issues

Fixes #1246

Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
# Conflicts:
#	src/test/java/dev/openfeature/sdk/HookSpecTest.java
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.65%. Comparing base (fc6f35e) to head (4f1919d).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1261      +/-   ##
============================================
+ Coverage     93.47%   93.65%   +0.18%     
- Complexity      464      465       +1     
============================================
  Files            43       43              
  Lines          1088     1088              
  Branches         86       86              
============================================
+ Hits           1017     1019       +2     
+ Misses           44       43       -1     
+ Partials         27       26       -1     
Flag Coverage Δ
unittests 93.65% <100.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrfwow chrfwow closed this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add evaluation details to finally hook stage
1 participant