-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add flag metadata #459
Conversation
676cf5a
to
ec8c6f9
Compare
Codecov Report
@@ Coverage Diff @@
## main #459 +/- ##
============================================
- Coverage 94.09% 93.65% -0.45%
+ Complexity 257 231 -26
============================================
Files 24 24
Lines 576 536 -40
Branches 35 33 -2
============================================
- Hits 542 502 -40
Misses 17 17
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@Kavindu-Dodan this all looks good to me, except that I'm not sure about throwing on failed retrieval. This seems like a typical eventuality, not an exceptional one. |
c089d01
to
2828442
Compare
Updated the implementation to avoid exceptions. Instead now we return null for missing key & value type differences , along with debug level log entry cc - @thisthat |
83243d4
to
b115442
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
b115442
to
207545b
Compare
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
207545b
to
e78fed7
Compare
@Kavindu-Dodan I rebased on main and resolved conflicts with @lopitz 's recent PR. I hope you don't mind. This looks good to me, and we have lots of approvals so I'm merging. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This PR
Is connected to #437 & completes the implementation of flag metadata spec implementation [1]
The implementation is backed by immutable
FlagMetadata
. If present, metadata gets propagated fromProviderEvaluation
toFlagEvaluationDetails
Tests were added to validate the construction as well as the propagation
[1] - open-feature/spec@74c373e