-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: missing targeting key should return null #849
fix: missing targeting key should return null #849
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #849 +/- ##
============================================
+ Coverage 95.15% 95.52% +0.36%
- Complexity 367 371 +4
============================================
Files 34 34
Lines 847 849 +2
Branches 50 52 +2
============================================
+ Hits 806 811 +5
+ Misses 22 20 -2
+ Partials 19 18 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
54ce066
to
f3b6bac
Compare
@liran2000 thanks a lot for the NPE fix :) |
Problem: getTargetingKey of missing targeting key causing NullPointerException Solution: getTargetingKey of missing targeting key returns null Signed-off-by: liran2000 <liran2000@gmail.com>
Signed-off-by: liran2000 <liran2000@gmail.com>
f3b6bac
to
495b583
Compare
Quality Gate passedIssues Measures |
Problem:
getTargetingKey of missing targeting key causing NullPointerException.
Solution:
getTargetingKey of missing targeting key returns null.
failing java-sdk-contrib CI:
When adopting #805, saw an issue when checking missing targeting key when it is required, causing the check to not work properly:
Related test check can be updated after this fix.