Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add evaluation details to finally hook stage #1109

Closed
beeme1mr opened this issue Dec 11, 2024 · 0 comments · Fixed by #1087
Closed

Add evaluation details to finally hook stage #1109

beeme1mr opened this issue Dec 11, 2024 · 0 comments · Fixed by #1087
Assignees
@beeme1mr

Comments

@beeme1mr
Copy link
Member

Add evaluation details to finally hook stage.

Notes

This breaks the signature of the finally stages based on this spec enhancement. It is not considered a breaking change to the SDK because hooks are marked as experimental in the spec, and the change has no impact on known hooks.

- finally(hookContext, hookHints)
+finally(hookContext, evaluationDetails, hookHints)

Acceptance criteria:

  • finally hook stage modified
  • associated tests

Follow ups:

  • update contribs
@beeme1mr beeme1mr self-assigned this Dec 11, 2024
@beeme1mr beeme1mr linked a pull request Dec 11, 2024 that will close this issue
feat: add evaluation details to finally hook #1087
Merged
@beeme1mr beeme1mr changed the title Add evaluation details to finally hook stage Add evaluation details to finally hook stage Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beeme1mr beeme1mr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add evaluation details to finally hook open-feature/js-sdk
1 participant
@beeme1mr