feat: add STALE pre-defined reason #898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
toddbaert
commented
Apr 2, 2024
beeme1mr
approved these changes
Apr 2, 2024
Member
|
@toddbaert loosely related to #893 |
thomaspoignant
approved these changes
Apr 2, 2024
toddbaert
pushed a commit
that referenced
this pull request
Apr 2, 2024
🤖 I have created a release *beep* *boop* --- ## [1.1.0](core-v1.0.0...core-v1.1.0) (2024-04-02) ### ✨ New Features * add STALE pre-defined reason ([#898](#898)) ([7f4f080](7f4f080)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com> Signed-off-by: openfeature-peer-update-bot <openfeature-peer-update-bot@openfeature.dev> Co-authored-by: openfeature-peer-update-bot <openfeature-peer-update-bot@openfeature.dev>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 3, 2024
This PR adds a new `useFlag` hook. This hook:
- returns an object supporting a react "query-style" API with relevant
properties: `const { value: newMessage, isError, reason, errorCode,
isAuthoritative, type } = useFlag('new-message', true);`
- supports ergonomic generics:
```
const { value: boolVal }: FlagQuery<boolean> = useFlag('bool-flag', true);
const { value: stringVal }: FlagQuery<string> = useFlag('string-flag', 'string');
const { value: objVal }: FlagQuery<{greeting: string}> = useFlag('obj-flag', { greeting: 'hi' });
```
- supports all the same options and features as other hooks (suspense,
etc)
This PR fixes some type bugs as well, and adds to the readme.
DEPENDS ON: #898
---------
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Co-authored-by: Juan Bernal <juanxwtf@gmail.com>
Co-authored-by: Pete Hodgson <github@thepete.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds STALE pre-defined reason, re-orders reasons in source to match spec.