refactor: export public option types #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
toddbaert
approved these changes
Dec 10, 2024
|
I'm just going to merge this since it's just renames and adding one export. I can't see any import cycles. |
beeme1mr
added a commit
that referenced
this pull request
Dec 18, 2024
🤖 I have created a release *beep* *boop* --- ## [0.4.10](react-sdk-v0.4.9...react-sdk-v0.4.10) (2024-12-18) ### 🔄 Refactoring * export public option types ([#1101](#1101)) ([16321c3](16321c3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com> Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com>
kevinmlong
pushed a commit
to kevinmlong/openfeature-js-sdk
that referenced
this pull request
Dec 21, 2024
🤖 I have created a release *beep* *boop* --- ## [0.4.10](open-feature/js-sdk@react-sdk-v0.4.9...react-sdk-v0.4.10) (2024-12-18) ### 🔄 Refactoring * export public option types ([open-feature#1101](open-feature#1101)) ([16321c3](open-feature@16321c3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com> Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com>
wichopy
pushed a commit
to wichopy/openfeature-js-sdk
that referenced
this pull request
Dec 31, 2024
## This PR - renames the `shared` folder to `internal` to prevent accident exports - export public option types ### Notes This will make it easier for devs who need access to the option types. --------- Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Will Chou <w.chou06@gmail.com>
wichopy
pushed a commit
to wichopy/openfeature-js-sdk
that referenced
this pull request
Dec 31, 2024
🤖 I have created a release *beep* *boop* --- ## [0.4.10](open-feature/js-sdk@react-sdk-v0.4.9...react-sdk-v0.4.10) (2024-12-18) ### 🔄 Refactoring * export public option types ([open-feature#1101](open-feature#1101)) ([16321c3](open-feature@16321c3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com> Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Will Chou <w.chou06@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
sharedfolder tointernalto prevent accident exportsNotes
This will make it easier for devs who need access to the option types.