refactor: Rename shutdown event to notready event #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabrizio Demaria <fdema@spotify.com>
fabriziodemaria
force-pushed
the
not-ready
branch
from
5638047
to
be97739
Compare
vahidlazio
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
"NotReady" is not an Event yet in the Spec (but it is a Status as of the day of writing this PR). However, this transitional change is supposed to bring this implementation one step closer to the Spec (note that "ShutDown" is neither and "Event" nor a "Status"). This also brings the current implementation closer to the Swift implementation.
Related Issues
Provider Statusfield from provider to SDK, refine semantics around ContextChange events spec#238