fix: Add missing poddisruptionbudget update verb #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Background --- Openfeature operator controller manager needs to be able to update pod disruption budgets as replica counts can be updated Changes --- * add update verb to manager role for pod disruption budgets Signed-off-by: woodyh <woodyh@blackmagicdesign.com>
wondertroy
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #722 +/- ##
==========================================
- Coverage 86.51% 86.25% -0.26%
==========================================
Files 19 19
Lines 1587 1681 +94
==========================================
+ Hits 1373 1450 +77
- Misses 173 184 +11
- Partials 41 47 +6 see 3 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
…dget permission Signed-off-by: woodyh <woodyh@blackmagicdesign.com>
beeme1mr
approved these changes
Nov 6, 2024
xvzf
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Openfeature operator controller manager needs to be able to update pod disruption budgets as replica counts can be updated
Related Issues
#717
Notes
After deploying v0.8.1 I noticed these new permissions were not in the role. I think I've missed some required change to get these reconciled in to the role resource.
Follow-up Tasks
How to test