Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: FlagsmithProvider #126

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

feat: FlagsmithProvider #126

wants to merge 19 commits into from

Conversation

ChrisLightfootWild
Copy link

@ChrisLightfootWild ChrisLightfootWild commented Mar 31, 2025 •
edited
Loading

This PR

  • adds new package, open-feature/flagsmith-provider
    • implements OpenFeature\interfaces\provider\Provider interface for Flagsmith
    • depends on flagsmith/flagsmith-php-client

Notes

image

Follow-up Tasks

How to test

$flagsmith = new Flagsmith\Flagsmith('YOUR_FLAGSMITH_API_KEY');

OpenFeatureAPI::setProvider(new FlagsmithProvider($flagsmith));

Run the tests with:

composer run dev:test

You should (hopefully) see the below output:
image

@ChrisLightfootWild
Initial Flagsmith provider.
4098a0b 
Signed-off-by: Chris Lightfoot-Wild <github-clw@wild.me.uk>
@ChrisLightfootWild
Added split config for Flagsmith.
9615e1e 
Signed-off-by: Chris Lightfoot-Wild <github-clw@wild.me.uk>
@ChrisLightfootWild
Flagsmith: added .gitattributes
9d23a4e 
Signed-off-by: Chris Lightfoot-Wild <github-clw@wild.me.uk>
@ChrisLightfootWild
Flagsmith: handle enabled/disabled state of flags.
6793ad3 
Signed-off-by: Chris Lightfoot-Wild <github-clw@wild.me.uk>
@ChrisLightfootWild
(ci) add Flagsmith to test matrix
9f09785 
Signed-off-by: Chris Lightfoot-Wild <github-clw@wild.me.uk>
@ChrisLightfootWild
(feat) Flagsmith resolveObjectValue should expect flag value to be en…
0485e53 
…coded JSON array

Signed-off-by: Chris Lightfoot-Wild <github-clw@wild.me.uk>
@ChrisLightfootWild
(feat) Flagsmith resolveObjectValue should not call json_decode on de…
e754566 
…faultValue

Signed-off-by: Chris Lightfoot-Wild <github-clw@wild.me.uk>
@ChrisLightfootWild
(style) FlagsmithProvider linting
4bce148 
Signed-off-by: Chris Lightfoot-Wild <github-clw@wild.me.uk>
@ChrisLightfootWild
(chore) remove unused Flagsmith dependencies
be6f4e2 
Signed-off-by: Chris Lightfoot-Wild <github-clw@wild.me.uk>
@ChrisLightfootWild
(chore) fix FlagsmithProvider complaints
25eaa2a 
Signed-off-by: Chris Lightfoot-Wild <github-clw@wild.me.uk>
@ChrisLightfootWild
(chore) fix FlagsmithProviderTest
9d2c70e 
Signed-off-by: Chris Lightfoot-Wild <github-clw@wild.me.uk>
@ChrisLightfootWild
(chore) bunp Flagsmith minimum PHP version to 8.1
2a8e686 
Signed-off-by: Chris Lightfoot-Wild <github-clw@wild.me.uk>
@ChrisLightfootWild
(style) fix Flagsmith TestOfflineHandler
1d9187e 
Signed-off-by: Chris Lightfoot-Wild <github-clw@wild.me.uk>
@ChrisLightfootWild
(test) added resolveBooleanValue tests to FlagsmithProvider
e0bf3b6 
Signed-off-by: Chris Lightfoot-Wild <github-clw@wild.me.uk>
@ChrisLightfootWild ChrisLightfootWild changed the title (feat): FlagsmithProvider feat: FlagsmithProvider Mar 31, 2025
@ChrisLightfootWild
(test) added resolveStringValue tests to FlagsmithProvider
381b541 
Signed-off-by: Chris Lightfoot-Wild <github-clw@wild.me.uk>
@ChrisLightfootWild
(style) fix FlagsmithProviderTest trailing comma
945fb94 
Signed-off-by: Chris Lightfoot-Wild <github-clw@wild.me.uk>
@ChrisLightfootWild
(test) added resolveIntegerValue tests to FlagsmithProvider
a33f93c 
Signed-off-by: Chris Lightfoot-Wild <github-clw@wild.me.uk>
@ChrisLightfootWild
(test) added resolveFloatValue tests to FlagsmithProvider
9b8b892 
Signed-off-by: Chris Lightfoot-Wild <github-clw@wild.me.uk>
@ChrisLightfootWild
(test) added resolveObjectValue tests to FlagsmithProvider
f10470c 
Signed-off-by: Chris Lightfoot-Wild <github-clw@wild.me.uk>
@ChrisLightfootWild ChrisLightfootWild marked this pull request as ready for review March 31, 2025 23:55
@ChrisLightfootWild ChrisLightfootWild requested a review from a team as a code owner March 31, 2025 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ChrisLightfootWild