Skip to content

ci: various fixes for linting #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 20, 2023
Merged

ci: various fixes for linting #81

merged 4 commits into from
May 20, 2023

Conversation

tcarrio
Copy link
Member

@tcarrio tcarrio commented May 20, 2023

This PR

  • resolves CI blockers

Related Issues

Notes

More to come as I work through issues in CI

Follow-up Tasks

How to test

If the CI tests pass we're good to move forward

tcarrio added 3 commits May 20, 2023 09:28
Signed-off-by: Tom Carrio <tom@carrio.dev>
Signed-off-by: Tom Carrio <tom@carrio.dev>
Signed-off-by: Tom Carrio <tom@carrio.dev>
@codecov
Copy link

codecov bot commented May 20, 2023

Codecov Report

Merging #81 (18a58b2) into main (5872cf5) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #81   +/-   ##
=======================================
  Coverage   59.76%   59.76%           
=======================================
  Files          34       34           
  Lines         507      507           
=======================================
  Hits          303      303           
  Misses        204      204           
Impacted Files Coverage Δ
hooks/DDTrace/src/_autoload.php 100.00% <100.00%> (ø)
hooks/OpenTelemetry/src/_autoload.php 100.00% <100.00%> (ø)
providers/Split/src/SplitProvider.php 81.39% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tcarrio tcarrio changed the title style: import dd-trace hook before use in _autoload.php ci: various fixes for linting May 20, 2023
@tcarrio
Copy link
Member Author

tcarrio commented May 20, 2023

Still need to fix up some Flagd tests.

Signed-off-by: Tom Carrio <tom@carrio.dev>
@tcarrio
Copy link
Member Author

tcarrio commented May 20, 2023

CI tests pass. This should unblock some more work with more safety 🛟

@tcarrio tcarrio merged commit 3727b13 into main May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant