fix: correct merging of contexts with targetingKey

Signed-off-by: Tommaso Tofacchi <tofacchitommaso@gmail.com>
open-feature · Oct 28, 2024 · c2375d3 · c2375d3
1 parent 712d8e4
commit c2375d3
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/src/implementation/flags/EvaluationContextMerger.php b/src/implementation/flags/EvaluationContextMerger.php
@@ -47,10 +47,10 @@ public static function merge(?EvaluationContextInterface ...$contexts): Evaluati
 
                 /** @var ?string $newTargetingKey */
                 $newTargetingKey = null;
-                if (!is_null($calculatedTargetingKey) && strlen($calculatedTargetingKey) > 0) {
-                    $newTargetingKey = $calculatedTargetingKey;
-                } elseif (!is_null($additionalTargetingKey) && strlen($additionalTargetingKey) > 0) {
+                if (!is_null($additionalTargetingKey) && strlen($additionalTargetingKey) > 0) {
                     $newTargetingKey = $additionalTargetingKey;
+                } elseif (!is_null($calculatedTargetingKey) && strlen($calculatedTargetingKey) > 0) {
+                    $newTargetingKey = $calculatedTargetingKey;
                 }
 
                 $mergedAttributes = AttributesMerger::merge(

diff --git a/tests/unit/EvaluationContextTest.php b/tests/unit/EvaluationContextTest.php
@@ -127,4 +127,17 @@ public function testEvaluationContextMerging(): void
 
         $this->assertEquals($expectedEvaluationContextAttributes, $actualEvaluationContextAttributes);
     }
+
+    public function testEvaluationContextMergingTargetingKey(): void
+    {
+        $firstEvaluationContext = new EvaluationContext('default');
+        $secondEvaluationContext = new EvaluationContext('merged_key');
+
+        $expectedEvaluationContextAttributes = 'merged_key';
+
+        $actualEvaluationContext = EvaluationContext::merge($firstEvaluationContext, $secondEvaluationContext);
+        $actualEvaluationContextAttributes = $actualEvaluationContext->getTargetingKey();
+
+        $this->assertEquals($expectedEvaluationContextAttributes, $actualEvaluationContextAttributes);
+    }
 }