fix: correct merging of contexts with targetingKey #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmito
force-pushed
the
fix/incorrect-context-merge
branch
from
548d605
to
c1429a8
Compare
Signed-off-by: Tommaso Tofacchi <tofacchitommaso@gmail.com>
mmito
force-pushed
the
fix/incorrect-context-merge
branch
from
c1429a8
to
c2375d3
Compare
beeme1mr
approved these changes
Oct 28, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #136 +/- ##
============================================
+ Coverage 95.19% 95.71% +0.52%
Complexity 227 227
============================================
Files 40 40
Lines 583 584 +1
============================================
+ Hits 555 559 +4
+ Misses 28 25 -3 ☔ View full report in Codecov by Sentry. |
|
@beeme1mr shall I add a test hitting the line that is currently missing per |
|
I view it as optional for a change like this. |
|
Thank you for the PR @mmito 👋 This looks good to me. I will go ahead and override the codecov, since it is still a net improvement on coverage, and merge this in |
tcarrio
approved these changes
Oct 28, 2024
beeme1mr
pushed a commit
that referenced
this pull request
Oct 28, 2024
🤖 I have created a release *beep* *boop* --- ## [2.0.10](2.0.9...2.0.10) (2024-10-28) ### 🐛 Bug Fixes * correct merging of contexts with targetingKey ([#136](#136)) ([3f141d7](3f141d7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Corrects the behavior of EvaluationContextMerger
merge()when using stringtargetingKey.Related Issues
Fixes #135
Notes
Follow-up Tasks
How to test
The
testEvaluationContextMergingTargetingKeytest in EvaluationContextTest.php has been added. The test fails without the proposed fix, as expected.