fix: address review comments

Signed-off-by: Federico Bond <federicobond@gmail.com>
open-feature · Jul 18, 2023 · 77f43f9 · 77f43f9
1 parent 4d1b078
commit 77f43f9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/open_feature/provider/in_memory_provider.py b/open_feature/provider/in_memory_provider.py
@@ -116,7 +116,8 @@ def _resolve(
         if flag is None:
             return FlagResolutionDetails(
                 value=default_value,
-                reason=Reason.DEFAULT,
-                variant=PASSED_IN_DEFAULT,
+                reason=Reason.ERROR,
+                error_code=ErrorCode.FLAG_NOT_FOUND,
+                error_message=f"Flag '{flag_key}' not found",
             )
         return flag.resolve(evaluation_context)
diff --git a/tests/provider/test_in_memory_provider.py b/tests/provider/test_in_memory_provider.py
@@ -1,5 +1,6 @@
 from numbers import Number
 
+from open_feature.exception.error_code import ErrorCode
 from open_feature.flag_evaluation.reason import Reason
 from open_feature.flag_evaluation.resolution_details import FlagResolutionDetails
 from open_feature.provider.in_memory_provider import InMemoryProvider, InMemoryFlag
@@ -24,8 +25,9 @@ def test_should_handle_unknown_flags_correctly():
     assert flag is not None
     assert flag.value is True
     assert isinstance(flag.value, bool)
-    assert flag.reason == Reason.DEFAULT
-    assert flag.variant == "Passed in default"
+    assert flag.reason == Reason.ERROR
+    assert flag.error_code == ErrorCode.FLAG_NOT_FOUND
+    assert flag.error_message == "Flag 'Key' not found"
 
 
 def test_calls_context_evaluator_if_present():