Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add evaluation details to finally hook stage #403

Closed
toddbaert opened this issue Dec 11, 2024 · 1 comment · Fixed by #423
Closed

Add evaluation details to finally hook stage #403

toddbaert opened this issue Dec 11, 2024 · 1 comment · Fixed by #423

Comments

@toddbaert
Copy link
Member

Add evaluation details to finally hook stage.

Notes

This breaks the signature of the finally stages based on this spec enhancement. It is not considered a breaking change to the SDK because hooks are marked as experimental in the spec, and the change has no impact on known hooks.

- finally(hookContext, hookHints)
+finally(hookContext, evaluationDetails, hookHints)

Acceptance criteria:

  • finally hook stage modified
  • associated tests

Follow ups:

  • update contribs
@chrfwow
Copy link
Contributor

chrfwow commented Jan 13, 2025

I would like to take this over

chrfwow added a commit to chrfwow/python-sdk that referenced this issue Jan 13, 2025
@chrfwow
Add evaluation details to finally hook stage open-feature#403
f1676e7 
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
@chrfwow chrfwow mentioned this issue Jan 14, 2025
Merged
chrfwow added a commit to chrfwow/python-sdk that referenced this issue Jan 14, 2025
@chrfwow
fixup! Add evaluation details to finally hook stage open-feature#403
71bedbd 
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
chrfwow added a commit to chrfwow/python-sdk that referenced this issue Jan 14, 2025
@chrfwow
fixup! Add evaluation details to finally hook stage open-feature#403
fc97b1b 
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
chrfwow added a commit to chrfwow/python-sdk that referenced this issue Jan 28, 2025
@chrfwow
Merge branch 'main' into Add-evaluation-details-to-finally-hook-stage-o…
cb8a432 
…pen-feature#403

# Conflicts:
#	tests/features/steps/steps.py
chrfwow added a commit to chrfwow/python-sdk that referenced this issue Jan 28, 2025
@chrfwow
fixup! Add evaluation details to finally hook stage open-feature#403
d0d74cf 
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
@chrfwow chrfwow mentioned this issue Jan 28, 2025
Merged
chrfwow added a commit to chrfwow/python-sdk that referenced this issue Jan 28, 2025
@chrfwow
fixup! Add evaluation details to finally hook stage open-feature#403
e803ae6 
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
chrfwow added a commit to chrfwow/python-sdk that referenced this issue Jan 28, 2025
@chrfwow
fixup! Add evaluation details to finally hook stage open-feature#403
6f71842 
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
chrfwow added a commit to chrfwow/python-sdk that referenced this issue Jan 28, 2025
@chrfwow
fixup! Add evaluation details to finally hook stage open-feature#403
07b512e 
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
chrfwow added a commit to chrfwow/python-sdk that referenced this issue Jan 28, 2025
@chrfwow
fixup! Add evaluation details to finally hook stage open-feature#403
81f15df 
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
chrfwow added a commit to chrfwow/python-sdk that referenced this issue Jan 29, 2025
@chrfwow
fixup! Add evaluation details to finally hook stage open-feature#403
66c4a8f 
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
gruebel added a commit to chrfwow/python-sdk that referenced this issue Jan 29, 2025
@gruebel
Merge branch 'main' into Add-evaluation-details-to-finally-hook-stage-o…
d37a56f 
…pen-feature#403
beeme1mr added a commit to chrfwow/python-sdk that referenced this issue Jan 29, 2025
@beeme1mr
Merge branch 'main' into Add-evaluation-details-to-finally-hook-stage-o…
005007d 
…pen-feature#403
beeme1mr pushed a commit that referenced this issue Jan 30, 2025
@chrfwow @gruebel
feat: Add evaluation details to finally hook stage #403 (#423)
9e9bb5c 
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Co-authored-by: Anton Grübel <anton.gruebel@gmail.com>
@openfeaturebot openfeaturebot mentioned this issue Jan 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add evaluation details to finally hook stage #403 chrfwow/python-sdk
2 participants
@chrfwow @toddbaert