Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: include STATIC and CACHED in provider reasons #166

Merged
merged 2 commits into from
Dec 19, 2022

Conversation

skyerus
Copy link
Contributor

@skyerus skyerus commented Dec 6, 2022

This PR

Revives the STATIC reason in order to determine which values are cacheable.
Introduces the CACHED reason in order to report to the client that the value has been retrieved from cache.

Related Issues

Fixes #165

Notes

Follow-up Tasks

How to test

Signed-off-by: Skye Gill <gill.skye95@gmail.com>
@skyerus skyerus requested a review from toddbaert as a code owner December 6, 2022 11:54
@beeme1mr beeme1mr requested review from justinabrahms and a team December 6, 2022 14:19
specification/types.md Outdated Show resolved Hide resolved
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though reasons are free form, I think these additions represent important information. We've seen the need for them come up in a few different implementations.

Co-authored-by: Todd Baert <toddbaert@gmail.com>
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
@beeme1mr beeme1mr merged commit 928d513 into open-feature:main Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amend provider's reasons to include static & cached
4 participants