define how context can be managed for named provider using static context paradigm #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
beeme1mr
commented
Dec 4, 2023
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
|
I think we should consider introducing the concept of Here's the PR that implements the proposed changes. Notice how the JSDocs refer to the scoped provider as a "named client". I think it would be more clear to say "namespaced provider". |
Kavindu-Dodan
approved these changes
Dec 4, 2023
Co-authored-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com> Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
toddbaert
reviewed
Dec 5, 2023
toddbaert
requested review from
kinyoklion,
thomaspoignant,
lukas-reining and
toddbaert
and removed request for
a team
toddbaert
approved these changes
Dec 5, 2023
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
…sing-the-static-context-paradigm
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
|
Leaving this open for additional feedback until Thursday, December 7. |
BuddhaBing
approved these changes
Dec 6, 2023
jonathannorris
approved these changes
Dec 8, 2023
beeme1mr
deleted the
218-manage-context-per-named-provider-when-using-the-static-context-paradigm
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Fixes #218
Notes
Addresses a limitation in the web SDK where it was impossible to manage context for specific providers. See this issue for more information.