Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OF#4423] Update addressNL component to render single/double column #695

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Jul 1, 2024

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 62.74%. Comparing base (7058f36) to head (d29284a).

Files Patch % Lines
src/formio/components/AddressNL.js 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #695      +/-   ##
==========================================
- Coverage   62.75%   62.74%   -0.02%     
==========================================
  Files         224      224              
  Lines        4159     4160       +1     
  Branches      844      844              
==========================================
  Hits         2610     2610              
- Misses       1426     1428       +2     
+ Partials      123      122       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/formio/components/AddressNL.js Outdated Show resolved Hide resolved
src/formio/components/AddressNL.js Outdated Show resolved Hide resolved
src/formio/components/AddressNL.js Outdated Show resolved Hide resolved
src/formio/components/AddressNL.stories.js Outdated Show resolved Hide resolved
src/formio/components/AddressNL.stories.js Outdated Show resolved Hide resolved
@vaszig vaszig force-pushed the of-4423/provide-a-dropdown-layout-for-single-or-two-columns-for-addressnl branch from 50e9798 to db4c3ec Compare July 2, 2024 14:45
src/formio/components/AddressNL.scss Outdated Show resolved Hide resolved
src/formio/components/AddressNL.scss Outdated Show resolved Hide resolved
@vaszig vaszig force-pushed the of-4423/provide-a-dropdown-layout-for-single-or-two-columns-for-addressnl branch from db4c3ec to d29284a Compare July 3, 2024 09:04
@sergei-maertens sergei-maertens force-pushed the of-4423/provide-a-dropdown-layout-for-single-or-two-columns-for-addressnl branch from d29284a to 5811ae2 Compare July 3, 2024 12:24
@sergei-maertens sergei-maertens merged commit 2047271 into main Jul 3, 2024
4 checks passed
@sergei-maertens sergei-maertens deleted the of-4423/provide-a-dropdown-layout-for-single-or-two-columns-for-addressnl branch July 3, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a non "column" view of AddressNL component
2 participants