Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AddressNL autocomplete: handle empty response #4430

Closed
vaszig opened this issue Jun 21, 2024 · 0 comments · Fixed by #4439
Closed

AddressNL autocomplete: handle empty response #4430

vaszig opened this issue Jun 21, 2024 · 0 comments · Fixed by #4439
Assignees
@vaszig
Labels
owner: utrecht
Milestone
Release 2.7.0

Comments

@vaszig
Copy link
Contributor

vaszig commented Jun 21, 2024

When we make the call to the API in order to retrieve the city and the streetName we may encounter an error, so we will get no data.

Now, the validate API call to the backend returns an empty response if this is the case, so we have a backend validation error concerning the secretCityStreename field. This could possibly be solved by returning empty string instead of an empty response and this could still calculate a secret.
@vaszig vaszig added the bug label Jun 21, 2024
@vaszig vaszig self-assigned this Jun 21, 2024
@vaszig vaszig added this to the Release 2.7.0 milestone Jun 21, 2024
@vaszig vaszig moved this from Todo to In Progress in Development Jun 24, 2024
@sergei-maertens sergei-maertens mentioned this issue Jun 24, 2024
Open
7 tasks
vaszig added a commit that referenced this issue Jun 25, 2024
@vaszig
[#4430] Fixed empty response in bag client
64b6322 
When we had no data from the API call, secretStreetCity was not created
and was an empty str, so it couldn't validate with the one that was
created in the backend validation. Now, we create one even when no data
is returned and this makes backend validation possible.
@vaszig vaszig moved this from In Progress to Implemented in Development Jun 25, 2024
@vaszig vaszig mentioned this issue Jun 25, 2024
Merged
9 tasks
@vaszig vaszig moved this from Implemented to In Progress in Development Jun 25, 2024
vaszig added a commit that referenced this issue Jun 25, 2024
@vaszig
[#4430] Fixed empty response in bag client
73c6c8a 
When we had no data from the API call, secretStreetCity was not created
and was an empty str, so it couldn't validate with the one that was
created in the backend validation. Now, we create one even when no data
is returned and this makes backend validation possible.
@vaszig vaszig moved this from In Progress to Implemented in Development Jun 25, 2024
sergei-maertens added a commit that referenced this issue Jun 26, 2024
@sergei-maertens
Merge pull request #4439 from open-formulieren/fix/4430-handle-empty-…
5363b22 
…bag-response-in-addressnl-autocomplete

[#4430] Handle empty response from bag client
@github-project-automation github-project-automation bot moved this from Implemented to Done in Development Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vaszig vaszig

Labels
owner: utrecht
Projects
Development
Archived in project
Milestone
Release 2.7.0
Development

Successfully merging a pull request may close this issue.

[#4430] Handle empty response from bag client open-formulieren/open-forms
2 participants
@joeribekker @vaszig