Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [#4713] Fix token exchange for BRP client #4740

Merged

Conversation

stevenbal
Copy link
Contributor

@stevenbal stevenbal commented Oct 8, 2024

Closes #4713

Changes

  • Set up Docker mock service for HaalCentraal BRP
  • Fix token exchange for BRP client

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@stevenbal stevenbal marked this pull request as draft October 8, 2024 12:51
@stevenbal stevenbal added the needs-backport Fix must be backported to stable release branch label Oct 8, 2024
@stevenbal stevenbal force-pushed the issue/4713-token-exchange-brp-family-members branch 2 times, most recently from deefd8b to 31c1c6b Compare October 8, 2024 13:14
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.56%. Comparing base (961e607) to head (7393002).
Report is 683 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4740   +/-   ##
=======================================
  Coverage   96.56%   96.56%           
=======================================
  Files         746      746           
  Lines       25185    25187    +2     
  Branches     3312     3313    +1     
=======================================
+ Hits        24320    24322    +2     
  Misses        601      601           
  Partials      264      264           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevenbal stevenbal force-pushed the issue/4713-token-exchange-brp-family-members branch from 31c1c6b to b259da3 Compare October 8, 2024 14:19
@stevenbal stevenbal marked this pull request as ready for review October 8, 2024 14:21
@stevenbal stevenbal force-pushed the issue/4713-token-exchange-brp-family-members branch 2 times, most recently from e346543 to d2d5b15 Compare October 8, 2024 14:54
@sergei-maertens sergei-maertens force-pushed the issue/4713-token-exchange-brp-family-members branch from d2d5b15 to 5d8c0cd Compare October 8, 2024 15:06
Copy link
Member

@sergei-maertens sergei-maertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why chromatic is failing 🤔

@sergei-maertens
Copy link
Member

I don't understand why chromatic is failing 🤔

okay looks like I broke it with the refactor, https://open-formulieren.github.io/open-forms/?path=/story/form-design-variablemapping--select-options is also failing. I'll look into it!

to ensure that token_exchange works correctly
previously the submission was not passed, causing token exchange to not work
@sergei-maertens sergei-maertens force-pushed the issue/4713-token-exchange-brp-family-members branch from 5d8c0cd to 7393002 Compare October 9, 2024 07:33
@sergei-maertens sergei-maertens merged commit d777da6 into master Oct 9, 2024
29 of 30 checks passed
@sergei-maertens sergei-maertens deleted the issue/4713-token-exchange-brp-family-members branch October 9, 2024 07:45
sergei-maertens pushed a commit that referenced this pull request Oct 9, 2024
previously the submission was not passed, causing token exchange to not work

Backport-of: #4740
sergei-maertens pushed a commit that referenced this pull request Oct 9, 2024
previously the submission was not passed, causing token exchange to not work

Backport-of: #4740
@sergei-maertens
Copy link
Member

Backports:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-backport Fix must be backported to stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Token exchange absent in brp family members calls to /kinderen and /partners
2 participants