-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 [#4713] Fix token exchange for BRP client #4740
🐛 [#4713] Fix token exchange for BRP client #4740
Conversation
deefd8b
to
31c1c6b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4740 +/- ##
=======================================
Coverage 96.56% 96.56%
=======================================
Files 746 746
Lines 25185 25187 +2
Branches 3312 3313 +1
=======================================
+ Hits 24320 24322 +2
Misses 601 601
Partials 264 264 ☔ View full report in Codecov by Sentry. |
31c1c6b
to
b259da3
Compare
e346543
to
d2d5b15
Compare
d2d5b15
to
5d8c0cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why chromatic is failing 🤔
okay looks like I broke it with the refactor, https://open-formulieren.github.io/open-forms/?path=/story/form-design-variablemapping--select-options is also failing. I'll look into it! |
to ensure that token_exchange works correctly
previously the submission was not passed, causing token exchange to not work
5d8c0cd
to
7393002
Compare
previously the submission was not passed, causing token exchange to not work Backport-of: #4740
previously the submission was not passed, causing token exchange to not work Backport-of: #4740
Closes #4713
Changes
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh
./bin/compilemessages_js.sh
Commit hygiene