-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-record vcr cassettes #4958
Merged
sergei-maertens
merged 9 commits into
master
from
release/3.0.0-re-record-vcr-cassettes
Dec 20, 2024
Merged
Re-record vcr cassettes #4958
sergei-maertens
merged 9 commits into
master
from
release/3.0.0-re-record-vcr-cassettes
Dec 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4958 +/- ##
=======================================
Coverage 96.62% 96.62%
=======================================
Files 760 760
Lines 25837 25837
Branches 3385 3385
=======================================
Hits 24964 24964
Misses 608 608
Partials 265 265 ☔ View full report in Codecov by Sentry. |
Had to update some tests as well since the commit 3916207 has added an extra version of the objecttype (pk=1) to the fixtures.
vaszig
force-pushed
the
release/3.0.0-re-record-vcr-cassettes
branch
from
December 19, 2024 14:21
13743a4
to
f703de5
Compare
It's okay - we don't need to re-record this cassette anyway. As long as 'we verify that the WSDL can be parsed and used correctly, we're good.
sergei-maertens
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4920 partly
Changes
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh
./bin/compilemessages_js.sh
Dockerfile/scripts
./bin
folderCommit hygiene