Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-record vcr cassettes #4958

Merged
merged 9 commits into from
Dec 20, 2024
Merged

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Dec 19, 2024

Closes #4920 partly

Changes

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@vaszig vaszig marked this pull request as draft December 19, 2024 11:55
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.62%. Comparing base (260a985) to head (d3f2d51).
Report is 10 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4958   +/-   ##
=======================================
  Coverage   96.62%   96.62%           
=======================================
  Files         760      760           
  Lines       25837    25837           
  Branches     3385     3385           
=======================================
  Hits        24964    24964           
  Misses        608      608           
  Partials      265      265           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vaszig vaszig force-pushed the release/3.0.0-re-record-vcr-cassettes branch from 13743a4 to f703de5 Compare December 19, 2024 14:21
@sergei-maertens sergei-maertens self-assigned this Dec 19, 2024
It's okay - we don't need to re-record this cassette anyway. As long as
'we verify that the WSDL can be parsed and used correctly, we're good.
@vaszig vaszig marked this pull request as ready for review December 20, 2024 10:54
@sergei-maertens sergei-maertens merged commit 9c6c899 into master Dec 20, 2024
37 checks passed
@sergei-maertens sergei-maertens deleted the release/3.0.0-re-record-vcr-cassettes branch December 20, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare release 3.0
2 participants