Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4825] Fix prefill when authentication is needed #5010

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Jan 10, 2025

Closes #4825

Changes

  • Run prefill plugin only when the authentication type matches the plugin's requirements.

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@vaszig vaszig marked this pull request as draft January 10, 2025 13:06
@vaszig vaszig force-pushed the fix/4825-2-digest-reports-prefill-failures-when-multiple-auth-flows branch 4 times, most recently from 2dcf088 to f3d8c70 Compare January 14, 2025 10:46
@vaszig vaszig marked this pull request as ready for review January 14, 2025 10:49
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.62%. Comparing base (f16d700) to head (bcf2262).
Report is 18 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5010   +/-   ##
=======================================
  Coverage   96.62%   96.62%           
=======================================
  Files         761      761           
  Lines       25961    25993   +32     
  Branches     3394     3395    +1     
=======================================
+ Hits        25084    25116   +32     
  Misses        611      611           
  Partials      266      266           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/openapi.yaml Outdated Show resolved Hide resolved
src/openapi.yaml Outdated Show resolved Hide resolved
src/openforms/prefill/api/serializers.py Outdated Show resolved Hide resolved
src/openforms/prefill/fields.py Outdated Show resolved Hide resolved
src/openforms/prefill/sources.py Outdated Show resolved Hide resolved
src/openforms/prefill/sources.py Show resolved Hide resolved
In case a form needs authentication and uses prefill, we need to make
sure that we run the plugin only when the authentication type matches
the plugin's requirements.
@vaszig vaszig force-pushed the fix/4825-2-digest-reports-prefill-failures-when-multiple-auth-flows branch from f3d8c70 to bcf2262 Compare January 14, 2025 15:19
@sergei-maertens sergei-maertens merged commit 41616e3 into master Jan 14, 2025
33 checks passed
@sergei-maertens sergei-maertens deleted the fix/4825-2-digest-reports-prefill-failures-when-multiple-auth-flows branch January 14, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Daily digest reporting prefill failures for forms that work with more then 1 auth "flow"
2 participants