Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to quickly include all form variables in JSON dump plugin #5070

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

viktorvanwijk
Copy link
Contributor

@viktorvanwijk viktorvanwijk commented Jan 31, 2025

Closes #5066

Changes

Add button to quickly include all form variables in JSON dump plugin

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.72%. Comparing base (5afe627) to head (62bc105).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5070   +/-   ##
=======================================
  Coverage   96.72%   96.72%           
=======================================
  Files         770      770           
  Lines       26523    26524    +1     
  Branches     3454     3452    -2     
=======================================
+ Hits        25655    25656    +1     
  Misses        606      606           
  Partials      262      262           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@viktorvanwijk viktorvanwijk changed the title Add button to quickly include all form varianles in JSON dump plugin Add button to quickly include all form variables in JSON dump plugin Feb 3, 2025
@viktorvanwijk viktorvanwijk force-pushed the 5066-add-possiblity-to-quickly-include-all-form-fields-in-the-data-to-be-sent-for-the-json-dump-registration-backend branch from b11b609 to 1013703 Compare February 3, 2025 08:37
@viktorvanwijk viktorvanwijk marked this pull request as ready for review February 4, 2025 14:10
@viktorvanwijk viktorvanwijk force-pushed the 5066-add-possiblity-to-quickly-include-all-form-fields-in-the-data-to-be-sent-for-the-json-dump-registration-backend branch from 820f230 to 62bc105 Compare February 5, 2025 10:16
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking now this might be better placed in Backend -> Admin styling?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant