Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace DataContainer with FormioData in evaluate_form_logic #5141

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

viktorvanwijk
Copy link
Contributor

Closes #5139

Changes

[Describe the changes here]

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@viktorvanwijk viktorvanwijk changed the title 🚧 [#5139] Remove DataContainer usage from iter_evaluate_… Replace DataContainer with FormioData in evaluate_form_logic Mar 6, 2025
It's a quick test to see what happens if we were to remove the DataContainer from iter_evaluate_rules, and replace it with a FormioData instance.

Also added support for FormioData in recursive_apply to fix several failing tests.

test_two_actions_on_the_same_variable illustrates what happens when two actions are performed on the same variable.
@viktorvanwijk viktorvanwijk force-pushed the cleanup/5139-replace-datacontainer-with-formiodata branch from ca656a6 to e16ae3f Compare March 10, 2025 16:07
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 89.47368% with 6 lines in your changes missing coverage. Please review.

Project coverage is 96.72%. Comparing base (4cb4b65) to head (e16ae3f).

Files with missing lines Patch % Lines
src/openforms/submissions/logic/datastructures.py 33.33% 4 Missing ⚠️
...ms/submissions/models/submission_value_variable.py 91.30% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5141      +/-   ##
==========================================
- Coverage   96.74%   96.72%   -0.03%     
==========================================
  Files         779      779              
  Lines       26774    26803      +29     
  Branches     3483     3487       +4     
==========================================
+ Hits        25903    25925      +22     
- Misses        607      613       +6     
- Partials      264      265       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace DataContainer with FormioData in evaluate_form_logic
1 participant