Skip to content

Tests: clarify extractTailAfterSummary semantics in codex-compaction #24

@riatzukiza

Description

@riatzukiza

Follow-up from PR #20 review (CodeRabbit comment on compaction helper tests): #20 (comment)

In test/codex-compaction.test.ts, the tests around extractTailAfterSummary currently read as if they are verifying a "summary-aware" helper, but the implementation actually returns the tail slice starting at the last role:"user" message.

This issue tracks:

  • Renaming/rewriting the extractTailAfterSummary tests so they explicitly describe the current semantics (tail after the last user message).
  • Avoiding test names or comments that imply a specific "summary marker" prefix while the implementation is still last-user-based.
  • Optionally, adding an additional test once we implement a dedicated summary marker (see also issue Compaction: make extractTailAfterSummary summary-aware #21) so test coverage remains clear if/when the helper becomes summary-aware.

We decided to keep the existing test wording in PR #20 and handle this clarification in a follow-up.

Metadata

Metadata

Assignees

No one assigned

    Labels

    compactionIssues related to conversation compaction and summary handlingeffort-smallSmall effort issues - less than 4 hours of workpriority-lowLow priority issues - minor enhancements or documentation fixes

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions