Merged
Conversation
* docs: reference @openhax/codex in test README * Delete spec/issue-11-docs-package.md
- Create shared clone utility (lib/utils/clone.ts) to eliminate 3+ duplicate implementations - Create InputItemUtils (lib/utils/input-item-utils.ts) for centralized text extraction - Centralize magic numbers in constants with SESSION_CONFIG, CONVERSATION_CONFIG, PERFORMANCE_CONFIG - Add ESLint cognitive complexity rules (max: 15) to prevent future issues - Refactor large functions to use shared utilities, reducing complexity - Update all modules to use centralized utilities and constants - Remove dead code and unused imports - All 123 tests pass, no regressions introduced Code quality improved from B+ to A- with better maintainability.
… edit workflow files
…paths - Update stale test counts to reflect actual numbers: * auth.test.ts: 16 → 27 tests * config.test.ts: 13 → 16 tests * request-transformer.test.ts: 30 → 123 tests * logger.test.ts: 5 → 7 tests * response-handler.test.ts: unchanged at 10 tests - Fix broken configuration file paths: * config/minimal-opencode.json (was config/minimal-opencode.json) * config/full-opencode.json (was config/full-opencode.json) Both configuration files exist in the config/ directory at repository root.
Device/stealth
- Update overview to reflect new gpt-5.1-codex-max model as default - Add note about xhigh reasoning effort exclusivity to gpt-5.1-codex-max - Document expanded model lineup matching Codex CLI
- Document new Codex Max support with xhigh reasoning - Note configuration changes and sample updates - Record automatic reasoning effort downgrade fix for compatibility
- Add gpt-5.1-codex-max configuration with xhigh reasoning support - Update model count from 20 to 21 variants - Expand model comparison table with Codex Max as flagship default - Add note about xhigh reasoning exclusivity and auto-downgrade behavior
- Add flagship Codex Max model with 400k context and 128k output limits - Configure with medium reasoning effort as default - Include encrypted_content for stateless operation - Set store: false for ChatGPT backend compatibility
- Change default model from gpt-5.1-codex to gpt-5.1-codex-max - Align minimal config with new flagship Codex Max model - Provide users with best-in-class default experience
- Add gpt-5.1-codex-max example configuration - Document xhigh reasoning effort exclusivity and auto-clamping - Remove outdated duplicate key example section - Clean up reasoning effort notes with new xhigh behavior
- Document new per-request JSON logging and rolling log files - Note environment variables for enabling live console output - Help developers debug with comprehensive logging capabilities
- Add rolling log file under ~/.opencode/logs/codex-plugin/ - Write structured JSON entries with timestamps for all log levels - Maintain per-request stage files for detailed debugging - Improve error handling and log forwarding to OpenCode app - Separate console logging controls from file logging
- Add model normalization for all codex-max variants - Implement xhigh reasoning effort with auto-downgrade for non-max models - Add Codex Max specific reasoning effort validation and normalization - Ensure compatibility with existing model configurations
Co-authored-by: riatzukiza <riatzukiza@users.noreply.github.com>
Co-authored-by: riatzukiza <riatzukiza@users.noreply.github.com>
…nd prep for Codex Max release; update request transforms and auth/session utilities; add lint-warnings spec
- Add debug logging to token refresh process in session-manager - Improve error handling in codex-fetcher for 401 responses - Fix fetch helper error handling for failed token refresh - Add comprehensive test coverage for token refresh scenarios - Add refresh-access-token spec documentation
- Update test/fetch-helpers.test.ts to properly validate refreshAndUpdateToken return value - Add type guard for OAuth auth type checking - Aligns test expectations with function's design of returning updated auth object - All 396 tests pass with no TypeScript errors
…re explicit Content-Type headers in OAuth server responses - Add test to verify host-provided prompt_cache_key is preserved over session cache key - Update OAuth server send helper to always include default Content-Type: text/plain; charset=utf-8 - Change headers parameter type to http.OutgoingHttpHeaders for stronger typing - Preserve existing HTML response Content-Type override behavior
Chore/codex max release review
- Remove hardcoded role whitelist in formatRole() - Return normalized role directly without validation - Add PR review documentation for CodeRabbit feedback
Guard disk logging and clarify clone/role utilities
## Critical Bug Fixes - Fix content-type header bug in fetch-helpers.ts - preserve original content-type for non-JSON responses - Fix cache fallback bug in codex.ts - wrap getLatestReleaseTag() in try/catch to ensure fallback chain works ## Test Improvements - Remove unused mocks in cache-warming.test.ts areCachesWarm tests - Fix mock leakage in index.test.ts by resetting sessionManager instance mocks - Add missing compactionDecision test case in codex-fetcher.test.ts - Remove redundant test case in codex-fetcher.test.ts ## Code Quality - Harden logger against JSON.stringify failures with try/catch fallback - Remove unused error parameter from logToConsole function - Update type signatures to match new function signatures ## Documentation - Add comprehensive PR analysis document in spec/pr-29-review-analysis.md All tests pass (398 passed, 2 skipped) with 82.73% coverage.
Docstrings generation was requested by @riatzukiza. * #34 (comment) The following files were modified: * `lib/auth/server.ts` * `lib/logger.ts` * `lib/request/fetch-helpers.ts`
📝 Add docstrings to `release/review-comments`
## Test Improvements - Enhance compaction decision test in codex-fetcher.test.ts to validate full flow: - Verify recordSessionResponseFromHandledResponse called with compacted response - Verify fetcher returns the compacted response with correct status/body - Ensure complete end-to-end compaction flow validation ## Code Quality - Fix linter warning in lib/auth/server.ts by prefixing unused parameter with underscore - Update corresponding type definition in lib/types.ts to match All tests continue to pass (398 passed, 2 skipped).
## Type Safety Improvements - Add OpencodeApp type with proper notify/toast method signatures - Add OpencodeClientWithApp intersection type for type-safe app access - Create isOpencodeClientWithApp type guard function - Replace (loggerClient as any)?.app with type-safe guarded access - Update emit function to use type guard for loggerClient.app access ## Benefits - Eliminates unsafe any type casting - Provides compile-time type checking for app property access - Maintains backward compatibility with existing OpencodeClient interface - Follows TypeScript best practices for type guards All tests continue to pass (398 passed, 2 skipped).
- Replace unsafe type casting with proper optional chaining - Update notifyToast to use correct Opencode SDK API structure - Use client.tui.showToast with proper body object format - Remove unnecessary type guard function - All tests pass and TypeScript compilation succeeds
Fix CodeRabbit review issues from PR #29
This was referenced Nov 20, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.