Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return 404 in "GET /orgs/{orgid}/status" when non-existent orgId is supplied #624

Closed
ewee33 opened this issue Jun 20, 2022 · 1 comment
Closed

Return 404 in "GET /orgs/{orgid}/status" when non-existent orgId is supplied #624

ewee33 opened this issue Jun 20, 2022 · 1 comment
Assignees
@naphelps
Labels
bug

Comments

@ewee33
Copy link
Contributor

ewee33 commented Jun 20, 2022

Currently in the route GET /orgs/{orgid}/status, if the caller supplies an orgId that doesn't exist in the exchange, this route will succeed with code 200 OK and return zeroes for all values in the response body. This behavior is unintended.

The intended behavior should be that this route returns a 404 NOT FOUND code when the supplied orgId does not exist in the exchange. This route should be updated with this new behavior, and the associated test suite should be updated as well to test this behavior.
@ewee33 ewee33 added the bug label Jun 20, 2022
@ewee33 ewee33 self-assigned this Jun 20, 2022
ewee33 added a commit to ewee33/exchange-api that referenced this issue Jun 27, 2022
@ewee33
Issue open-horizon#624: GET /orgs/{orgid}/status now returns 404 when…
3d08537 
… the specified orgId does not exist

Signed-off-by: Ethan Weaver <emw0022@mix.wvu.edu>
@naphelps naphelps self-assigned this Oct 14, 2024
@naphelps naphelps mentioned this issue Oct 31, 2024
Merged
@naphelps
Copy link
Member

naphelps commented Nov 5, 2024

Fixed in v2.126.0.

@naphelps naphelps closed this as completed Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@naphelps naphelps

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ewee33 @naphelps