Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding arch field to node entry #144

Merged
merged 12 commits into from
May 22, 2019
Merged

Adding arch field to node entry #144

merged 12 commits into from
May 22, 2019

Conversation

sf2ne
Copy link
Collaborator

@sf2ne sf2ne commented May 22, 2019

This PR references: open-horizon/anax#916

This PR includes

  1. the arch field was added to the node entry as an optional field
  2. corresponding tests
  3. Updates to README.md to include some fixes and the new version

bmpotter
bmpotter approved these changes May 22, 2019
View reviewed changes
Copy link
Member

@bmpotter bmpotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Great job!

@bmpotter bmpotter merged commit 5fe3be5 into open-horizon:master May 22, 2019
@sf2ne sf2ne deleted the archnodeentry branch May 22, 2019 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmpotter bmpotter bmpotter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sf2ne @bmpotter