Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small changes to get travis working #150

Merged
merged 1 commit into from
Jun 6, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -56,14 +56,14 @@ clean: clean-exec-image
clean-exec-image:
- docker rm -f $(DOCKER_NAME) 2> /dev/null || :
- docker rmi $(image-string):{$(DOCKER_TAG),$(DOCKER_LATEST)} 2> /dev/null || :
rm -f .docker-exec .docker-exec-run
rm -f .docker-exec*

# Also remove the bld image/container
clean-all: clean
- docker rm -f $(DOCKER_NAME)_bld 2> /dev/null || :
- docker rmi $(image-string):bld 2> /dev/null || :
- docker network remove $(DOCKER_NETWORK) 2> /dev/null || :
rm -f .docker-bld .docker-network
rm -f .docker-*

# rem-docker-bld:
# - docker rm -f $(DOCKER_NAME)_bld 2> /dev/null || :
Expand Down
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,10 @@ To build an exchange container with code that is targeted for a git branch:
- If maxAgreements>1, for CS, in search don't return node to agbot if agbot from same org already has agreement for same service.
- Consider changing all creates to POST, and update (via put/patch) return codes to 200

## Changes in 1.86.0

- Fixed ExchConfigSuites so it works with default config.json for `make test` in travis

## Changes in 1.85.0

- Added use of ICP self-signed cert
Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/version.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.85.0
1.86.0
5 changes: 1 addition & 4 deletions src/test/scala/exchangeapi/ExchConfigSuite.scala
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,11 @@ import com.horizon.exchangeapi._
class ExchConfigSuite extends FunSuite {
test("ExchConfig tests") {
ExchConfig.load()
// Note: this test needs to work with the default version of config.json that is in src/main/resources (so that 'make test' in travis works)
assert(ExchConfig.getInt("api.limits.maxNodes") === 10000)
//assert(ExchConfig.getInt("api.limits.maxAgbots") === 1000) // <- i usually locally test this as 0
assert(ExchConfig.getInt("api.limits.maxAgreements") === 0)
assert(ExchConfig.getInt("api.limits.maxMessagesInMailbox") === 10000)

assert(ExchConfig.getString("api.db.driverClass") === "org.postgresql.Driver")
assert(ExchConfig.getString("api.db.jdbcUrl").startsWith("jdbc:"))
// assert(ExchConfig.getString("api.db.user") === "admin" || ExchConfig.getString("api.db.user") === "bp" || ExchConfig.getString("api.db.user") === "sadiyahfaruk") // the local test db name is my user
assert(ExchConfig.getInt("api.db.minPoolSize") === 1)
assert(ExchConfig.getInt("api.db.acquireIncrement") === 1)
assert(ExchConfig.getInt("api.db.maxPoolSize") === 50)
Expand Down