New exchange search API to return how many nodes a particular service is currently running on #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmpotter
reviewed
Sep 14, 2019
| val orgService = "%|"+orgid+"/"+service+"|%" | ||
| logger.info("SADIYAH: orgService: " + orgService) | ||
| val q = for { | ||
| (n, s) <- (NodesTQ.rows.filter(_.orgid === orgid)) join (NodeStatusTQ.rows.filter(_.runningServices like orgService)) on (_.id === _.nodeId) |
There was a problem hiding this comment.
For future reference, be aware that if there were more than 1 status resource for a particular node id, then node id would be repeated in your yield (and then you would have to remove duplicates before sending them to the client). In this case you are safe, because there can only ever be at most 1 status resource per node.
bmpotter
reviewed
Sep 14, 2019
| assert(postResp.nodes.head === "NodesSuiteTests/n1") | ||
| assert(postResp.nodes(1) === "NodesSuiteTests/n2") | ||
| assert(postResp.nodes.contains("NodesSuiteTests/n1")) | ||
| assert(postResp.nodes.contains("NodesSuiteTests/n2")) |
There was a problem hiding this comment.
Thx for fixing this. I actually hit this once yesterday when running the test suites, but didn't have time to investigate, and reran the test suites and then everything worked (because it randomly depended on what order they came back in), so i moved on. But it left a nagging concern, but now that concern is gone :)
bmpotter
reviewed
Sep 14, 2019
bmpotter
approved these changes
Sep 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR references:
This PR includes:
runningServicesfield tostatusresource innodesrunningServiceson every PUT