Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POST /orgs/{id}/services/{id}/search doesn't account for nodes running an IBM service #226

Merged
merged 5 commits into from
Sep 18, 2019

Conversation

sf2ne
Copy link
Collaborator

@sf2ne sf2ne commented Sep 18, 2019

This PR references: #224

This PR contains:

  • moving POST /orgs/{id}/services/{id}/search to NodesRoutes.scala
  • renaming route to POST /v1/orgs/{orgid}/search/nodes/service where {orgid} is always the orgid of the user sending the request
  • changing the input body to be { "orgid": "string", "serviceURL": "string", "serviceVersion": "string", "serviceArch": "string" }
  • changing the filter so that nodes are checked to be in org of user not org of service
  • moving over the unit tests to NodesSuite.scala and edit them to work with new input body
  • adding unit tests to test specifically the case of IBM services running on user-cluster nodes

@bmpotter bmpotter merged commit e714fab into open-horizon:master Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants