Notification System Fixes - Changes Route #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR references:
#258
#265
This PR contains:
POST /v1/orgs/{orgid}/search/nodes/error/changesroute query so it gets all public changes, not just ones from the IBM orgmaxChangeIdOfQueryto the response, which is the highest changeId from the db query (so its not the highest changeId in the response necessarily, but its the highest changeId that they could have at the time of the request) So essentially if the response gets cut off its how many changes are potentially left to consumeidand theresourceitself so that changes for the same id but different resources aren't smushed together