Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth fixes #275

Merged
merged 7 commits into from
Jan 21, 2020
Merged

Auth fixes #275

merged 7 commits into from
Jan 21, 2020

Conversation

bmpotter
Copy link
Member

  • Fixed issue 262 - get icp cluster name once at the beginning
  • Fixed issue 256 - trying to access a non-existent resource in another org incorrectly returned 403 instead of 404
  • Fixed issue 264 - for auth exceptions, prefer returning retryable http codes
  • Verified authentication using OCP
  • Modified use of ICP_EXTERNAL_MGMT_INGRESS env var so it can optionally have https:// prepended

@bmpotter bmpotter requested a review from sf2ne January 21, 2020 20:55
sf2ne
sf2ne approved these changes Jan 21, 2020
View reviewed changes
Copy link
Collaborator

@sf2ne sf2ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bmpotter bmpotter merged commit ea7f75b into open-horizon:master Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sf2ne sf2ne sf2ne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmpotter @sf2ne