Fix iamapikey bug #280
Merged
Fix iamapikey bug #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bmpotter
commented
Jan 23, 2020
bmpotter
commented
- Fixed the logging of rejections
- Fixed listing all of a resource type from another org
- Added separate way to query icp/ocp exchange org
sf2ne
approved these changes
Jan 23, 2020
| userRow <- fetchUser(orgId, userInfo) | ||
| userAction <- { | ||
| logger.debug(s"userRow: $userRow") |
There was a problem hiding this comment.
Can we actually leave this log in? Is it ok because it's a debug log?
There was a problem hiding this comment.
if you are worried about the pw, it is bcrypted
| @@ -486,7 +490,7 @@ object IbmCloudAuth { | |||
| //logger.error(s"IAM authentication succeeded, but no matching exchange org with a cloud account id was found for ${authInfo.org}") | |||
| DBIO.failed(OrgNotFound(authInfo.org)) | |||
| } else if (authInfo.keyType == "iamtoken" && userInfo.accountId == "") { | |||
| //todo: this is the case with tokens from the edge mgmt ui (because we don't get the accountId when we validate an iamtoken). The ui already verified the org and is using the right one, | |||
| //todx: this is the case with tokens from the edge mgmt ui (because we don't get the accountId when we validate an iamtoken). The ui already verified the org and is using the right one, | |||
There was a problem hiding this comment.
oh, ya, i actually did that on purpose, because that code is commented out. I'm going to get rid of that block of commented out code in the next PR. (I was just really unsure of that change.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.