Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification Framework Agbot Case #325

Merged
merged 5 commits into from
Mar 10, 2020
Merged

Notification Framework Agbot Case #325

merged 5 commits into from
Mar 10, 2020

Conversation

sf2ne
Copy link
Collaborator

@sf2ne sf2ne commented Mar 9, 2020 •
edited
Loading

  • added "orgList": ["", "", ""] optional field in request body, that is a list of orgs that the agbot wants changes in
  • restructured the filters to more cleanly allow for agbot case
  • added agbot filter where if the agbot is a general agbot follow the user case filter and if the agbot is a "Super" agbot then it gets back all changes in the orgList that it sent in
  • allowed for wildcard case "" or "*" where if orgList: [""] or orgList: ["*"] then the agbot gets back all changes from all orgs
  • added some validation for maxRecords (set some cap of how high maxRecords can actually go)
  • set the maxRecords cap in config
  • relevant tests
  • fix for issues with Scalatest 3.1 release

@sf2ne sf2ne requested a review from bmpotter March 10, 2020 12:37
@bmpotter bmpotter merged commit 02ff958 into open-horizon:master Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmpotter bmpotter bmpotter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sf2ne @bmpotter