Issues: 455, 456, 458 - Timeouts and msgs #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 4, 2021 00:47
Signed-off-by: Bruce Potter <bp@us.ibm.com>
…re 0. Issue 458: Lower default values of resourceChanges ttl and cleanupInterval Signed-off-by: Bruce Potter <bp@us.ibm.com>
dlarson04
reviewed
Feb 4, 2021
| db.run(AgbotAgreementsTQ.getNumOwned(compositeId).result.flatMap({ xs => | ||
| val maxAgreements = ExchConfig.getInt("api.limits.maxAgreements") | ||
| val getNumOwnedDbio = if (maxAgreements == 0) DBIO.successful(0) else AgbotAgreementsTQ.getNumOwned(compositeId).result // avoid DB read for this if there is no max | ||
| db.run(getNumOwnedDbio.flatMap({ xs => | ||
| logger.debug("PUT /orgs/"+orgid+"/agbots/"+id+"/agreements/"+agrId+" num owned: "+xs) |
There was a problem hiding this comment.
Wondering if this debug message will be confusing to someone looking at logs for the case where maxAgreements and maxMessages will be 0. The log message will indicate that "num owned" will be 0 when in fact the code didn't check the value. Same comment for the places in NodeRoutes
There was a problem hiding this comment.
Ah, good catch, i missed that one. I'll fix...
dlarson04
reviewed
Feb 4, 2021
| // Remove msgs whose TTL is past, then check the mailbox is not full, then get the node publicKey, then write the agbotmsgs row, all in the same db.run thread | ||
| db.run(AgbotMsgsTQ.getNumOwned(compositeId).result.flatMap({ xs => | ||
| db.run(getNumOwnedDbio.flatMap({ xs => | ||
| logger.debug("POST /orgs/"+orgid+"/agbots/"+id+"/msgs mailbox size: "+xs) |
There was a problem hiding this comment.
same comment for the debug message for mailbox size
Signed-off-by: Bruce Potter <bp@us.ibm.com>
dlarson04
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
akka.http.server.request-timeoutto45smaxMessagesInMailboxandmaxAgreementsare0which is default and means unlimited