-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ucd] [char] [utils] Make libraries no_std #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing `fmt::Display` under `no_std` can get too much overhead, therefore it's moved to `tests/` so it can use `std::string` and friends.
Add `std` feature, which enabled the API based on `std::collections::Bound`. Add example code that tests the library in use-std environment. (A no-std example to be added later.)
bors: r+ |
bors bot
added a commit
that referenced
this pull request
Nov 6, 2017
179: [ucd] [char] [utils] Make libraries no_std r=behnam a=behnam Most of the transition was a matter of changing the namespace from `std` to `core`. * Unit tests for `Display` implementations are moved into integration tests, allowing use of `format!()` in test code. * [`char-range`] needed special attention, because of having an API using `std::collections::Bound` as input. Although the datatype is safe for core, it's part of `liballoc` APIs and therefore not available in `libcore`. Therefore, a new `std` feature is added to the package, which enables the part of the API. * [`char-range`] Feature implementations are refactored into separate files to simplify configuration conditioning. * [`char-property`] To be able to be used in `no_std` libraries, had to bring in some code for ASCII-case-insensitive char and str matching. * [`char-property`] The `char_property!()` macro now depends on the caller package to include `extern crate core;` explicitly iff it's a normal (use-std) package.
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the transition was a matter of changing the namespace from
std
tocore
.Unit tests for
Display
implementations are moved into integration tests, allowing use offormat!()
in test code.[
char-range
] needed special attention, because of having an API usingstd::collections::Bound
as input. Although the datatype is safe for core, it's part ofliballoc
APIs and therefore not available inlibcore
. Therefore, a newstd
feature is added to the package, which enables the part of the API.[
char-range
] Feature implementations are refactored into separate files to simplify configuration conditioning.[
char-property
] To be able to be used inno_std
libraries, had to bring in some code for ASCII-case-insensitive char and str matching.[
char-property
] Thechar_property!()
macro now depends on the caller package to includeextern crate core;
explicitly iff it's a normal (use-std) package.Tracker: #144