Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: Enable Windows and MacOS builds #237

Merged
merged 2 commits into from
Oct 21, 2020
Merged

Conversation

behnam
Copy link
Member

@behnam behnam commented Nov 4, 2018

This change is Reviewable

@behnam
Copy link
Member Author

behnam commented Nov 4, 2018

bors: r+

bors bot added a commit that referenced this pull request Nov 4, 2018
237: travis: Enable Windows and MacOS builds r=behnam a=behnam



<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/open-i18n/rust-unic/237)
<!-- Reviewable:end -->


Co-authored-by: Behnam Esfahbod <behnam@zwnj.org>
@bors
Copy link
Contributor

bors bot commented Nov 4, 2018

Timed out

@behnam behnam force-pushed the travis-1 branch 4 times, most recently from 2c47588 to 946ff07 Compare November 5, 2018 09:29
@behnam
Copy link
Member Author

behnam commented Nov 5, 2018

bors: r+

bors bot added a commit that referenced this pull request Nov 5, 2018
237: travis: Enable Windows and MacOS builds r=behnam a=behnam



<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/open-i18n/rust-unic/237)
<!-- Reviewable:end -->


Co-authored-by: Behnam Esfahbod <behnam@zwnj.org>
@bors
Copy link
Contributor

bors bot commented Nov 5, 2018

Timed out

@CAD97
Copy link
Collaborator

CAD97 commented Jul 24, 2019

bors: r=behnam

bors bot added a commit that referenced this pull request Jul 24, 2019
237: travis: Enable Windows and MacOS builds r=behnam a=behnam



<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/open-i18n/rust-unic/237)
<!-- Reviewable:end -->


252: Clippy fixes and changing refs to Copy r=CAD97 a=JamesHinshelwood

Updated clippy allows from `cfg_attr` to proc-macro style.
Fixed #241 + more - Changed a few `impl`s to take `self` instead of `&self`, when they are `Copy` types.

`cargo clippy` should run without any warnings now.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/open-i18n/rust-unic/252)
<!-- Reviewable:end -->


Co-authored-by: Behnam Esfahbod <behnam@zwnj.org>
Co-authored-by: JamesHinshelwood <jameshinshelwood1@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jul 24, 2019

Build failed (retrying...)

bors bot added a commit that referenced this pull request Jul 24, 2019
237: travis: Enable Windows and MacOS builds r=behnam a=behnam



<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/open-i18n/rust-unic/237)
<!-- Reviewable:end -->


Co-authored-by: Behnam Esfahbod <behnam@zwnj.org>
@bors
Copy link
Contributor

bors bot commented Jul 24, 2019

Build failed

@behnam behnam force-pushed the travis-1 branch 2 times, most recently from 54fe329 to 79eda44 Compare October 20, 2020 08:54
@behnam
Copy link
Member Author

behnam commented Oct 21, 2020

bors: r+

@bors
Copy link
Contributor

bors bot commented Oct 21, 2020

Build succeeded:

  • continuous-integration/travis-ci/push

@bors bors bot merged commit 41cd2b0 into open-i18n:master Oct 21, 2020
@behnam behnam deleted the travis-1 branch October 21, 2020 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants