Raunak/informal q2 audit patches · open-ibc/vibc-core-smart-contracts@11f45a3

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Run npm run lint: contracts/base/GeneralMiddleware.sol#L21

imported name Ibc is not used

Run npm run lint: contracts/base/GeneralMiddleware.sol#L48

Variable name must be in mixedCase

Run npm run lint: contracts/base/GeneralMiddleware.sol#L66

Named parameters missing. MIN unnamed argumenst is 4

Run npm run lint: contracts/base/GeneralMiddleware.sol#L77

Named parameters missing. MIN unnamed argumenst is 4

Run npm run lint: contracts/base/GeneralMiddleware.sol#L80

All public or external methods in a contract must override a definition from an interface

Run npm run lint: contracts/base/GeneralMiddleware.sol#L96

Named parameters missing. MIN unnamed argumenst is 4