add inline comment for why state modifications in channelClosing happ…

…en even on dapp revert
open-ibc · May 7, 2024 · afe0f86 · afe0f86
1 parent b8e1281
commit afe0f86
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/contracts/core/Dispatcher.sol b/contracts/core/Dispatcher.sol
@@ -441,6 +441,8 @@ contract Dispatcher is OwnableUpgradeable, UUPSUpgradeable, ReentrancyGuard, IDi
             )
         );
 
+        // Note: We delete the portChannelMap here even on Dapp revert to avoid having a case where a dapp deployed with
+        // a faulty callback cannot close a channel (as is done on channelCloseInit)
         delete _portChannelMap[portAddress][channelId];
         if (success) {
             emit ChannelCloseConfirm(portAddress, channelId);