Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raunak/hex to str fix #80

Merged
merged 1 commit into from
May 7, 2024
Merged

Raunak/hex to str fix #80

merged 1 commit into from
May 7, 2024

Conversation

RnkSngh
Copy link
Collaborator

@RnkSngh RnkSngh commented Apr 10, 2024

PR to fix the IBCUtils from hex str to address conversion + adding some fuzz tests for this!

Summary by CodeRabbit

  • New Features

    • Enhanced smart contract functionalities for the vIBC protocol, including improved channel management and packet handling.
    • Added new smart contracts for demo purposes and integration templates.
    • Introduced utility functions and error handling libraries for IBC operations.
  • Documentation

    • Updated and detailed documentation across various smart contracts to clarify roles, interactions, and functionalities.
  • Bug Fixes

    • Refined contract logic and function visibility to ensure consistency and robustness in channel and packet management.
  • Tests

    • Expanded test suites to cover new functionalities such as packet acknowledgments, channel closing, and timeout handling in cross-chain communication.
  • Refactor

    • Updated import statements and refactored contracts to comply with new version compatibilities and enhanced architectural requirements.

Copy link

coderabbitai bot commented Apr 10, 2024

Warning

Rate Limit Exceeded

@RnkSngh has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 12 minutes and 24 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 683fc26 and fa51209.

Walkthrough

This update enhances the vIBC protocol's smart contracts, focusing on robust channel management, packet handling, and system upgrades. It introduces new interfaces and utilities, refines existing contracts, and expands testing coverage to ensure system integrity and flexibility. The changes emphasize clarity, efficiency, and future scalability.

Changes

Files Change Summary
.gitignore, README.md Updated to include new coverage entries and detailed descriptions of core smart contracts.
contracts/.../GeneralMiddleware.sol, contracts/.../Earth.sol, contracts/.../Mars.sol Improved documentation and modified import statements.
contracts/core/..., contracts/interfaces/..., contracts/libs/..., contracts/utils/... Major updates across core contracts, interfaces, and libraries for enhanced functionality and compatibility.
test/... Expanded testing for new functionalities and updated import paths and references in existing tests.

🐇✨
In the realm of code, under digital skies,
A rabbit hopped by, with bright, keen eyes.
"Behold," it squeaked, with joy it speaks,
"New paths we weave, through cyber creeks!
With every line, our dreams entwine,
Crafting worlds, bit by bit—divine!" 🌟🌍
🐇💻


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@RnkSngh RnkSngh linked an issue Apr 10, 2024 that may be closed by this pull request
@RnkSngh RnkSngh changed the base branch from main to v2 April 10, 2024 21:51
@RnkSngh RnkSngh requested a review from dshiell April 10, 2024 21:51
@RnkSngh
Copy link
Collaborator Author

RnkSngh commented Apr 10, 2024

linting is failing but this should be fixed in the upgrade testing PR

@RnkSngh RnkSngh requested a review from nicopernas April 10, 2024 21:53
@RnkSngh RnkSngh changed the base branch from v2 to multi-client April 23, 2024 21:59
@RnkSngh RnkSngh changed the base branch from multi-client to raunak/upgrade-testing April 24, 2024 17:47
@RnkSngh RnkSngh force-pushed the raunak/hexToStr-fix branch from 4436346 to 6403264 Compare April 24, 2024 17:55
@RnkSngh RnkSngh force-pushed the raunak/upgrade-testing branch 2 times, most recently from dee7968 to 7e2d744 Compare April 25, 2024 15:42
@RnkSngh RnkSngh force-pushed the raunak/upgrade-testing branch 5 times, most recently from b774356 to 3161ac7 Compare May 6, 2024 18:21
@RnkSngh RnkSngh force-pushed the raunak/hexToStr-fix branch from 6403264 to 46965ea Compare May 6, 2024 20:11
Copy link
Collaborator

@dshiell dshiell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RnkSngh RnkSngh force-pushed the raunak/hexToStr-fix branch from 46965ea to f808e61 Compare May 7, 2024 13:18
@RnkSngh RnkSngh force-pushed the raunak/upgrade-testing branch 3 times, most recently from 70df3c0 to 1a4ecea Compare May 7, 2024 16:32
@RnkSngh RnkSngh force-pushed the raunak/hexToStr-fix branch from f808e61 to 528eded Compare May 7, 2024 16:48
Base automatically changed from raunak/upgrade-testing to main May 7, 2024 17:06
@RnkSngh RnkSngh force-pushed the raunak/hexToStr-fix branch from 528eded to fa51209 Compare May 7, 2024 17:14
@RnkSngh RnkSngh merged commit 6d867ef into main May 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix hex str to address
3 participants